search

UBICenter / uk

Simulations of UBI in the UK
MIT License
3 stars 6 forks source link

Update notebook #29

Closed nikhilwoodruff closed 3 years ago

nikhilwoodruff commented 3 years ago

Updates the notebook with formatting suggestions, and adds an exported Python script to generate the figures in different file formats.

pep8speaks commented 3 years ago

Hello @nikhilwoodruff! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 35:80: E501 line too long (229 > 79 characters) Line 55:1: E302 expected 2 blank lines, found 1 Line 56:3: E111 indentation is not a multiple of four Line 57:3: E111 indentation is not a multiple of four Line 61:1: E305 expected 2 blank lines after class or function definition, found 1 Line 61:1: E402 module level import not at top of file Line 62:1: E402 module level import not at top of file Line 63:1: E402 module level import not at top of file Line 66:1: E402 module level import not at top of file Line 148:1: E303 too many blank lines (3) Line 170:80: E501 line too long (237 > 79 characters) Line 172:80: E501 line too long (442 > 79 characters) Line 256:80: E501 line too long (295 > 79 characters) Line 267:1: E402 module level import not at top of file Line 331:80: E501 line too long (122 > 79 characters) Line 369:80: E501 line too long (162 > 79 characters) Line 400:80: E501 line too long (123 > 79 characters) Line 406:1: E402 module level import not at top of file Line 455:80: E501 line too long (175 > 79 characters) Line 459:80: E501 line too long (337 > 79 characters) Line 465:1: E402 module level import not at top of file Line 466:1: E402 module level import not at top of file Line 505:80: E501 line too long (153 > 79 characters) Line 506:80: E501 line too long (150 > 79 characters) Line 601:1: E402 module level import not at top of file Line 602:1: E402 module level import not at top of file Line 641:80: E501 line too long (153 > 79 characters) Line 642:80: E501 line too long (150 > 79 characters) Line 745:80: E501 line too long (445 > 79 characters) Line 751:1: E402 module level import not at top of file Line 823:80: E501 line too long (88 > 79 characters) Line 824:80: E501 line too long (108 > 79 characters) Line 862:80: E501 line too long (129 > 79 characters) Line 879:1: E402 module level import not at top of file Line 980:33: W292 no newline at end of file

MaxGhenis commented 3 years ago

Sorry I'm just getting to this. Seems like a lot of code duplication, could you add the figure export to the notebook instead, so immediately after showing it it also exports it?