UBod / msa

R package for multiple sequence alignment
https://github.com/UBod/msa
17 stars 11 forks source link

The msg package wan't install on a M1 based apple computer #20

Closed BC19RG closed 1 year ago

BC19RG commented 2 years ago

if (!require("BiocManager", quietly = TRUE))

  • install.packages("BiocManager") BiocManager::install("msa") 'getOption("repos")' replaces Bioconductor standard repositories, see '?repositories' for details

replacement repositories: CRAN: https://cran.rstudio.com/

Bioconductor version 3.15 (BiocManager 1.30.19), R 4.2.2 (2022-10-31) Installing package(s) 'msa' Warning: unable to access index for repository https://bioconductor.org/packages/3.15/bioc/bin/macosx/big-sur-arm64/contrib/4.2: cannot open URL 'https://bioconductor.org/packages/3.15/bioc/bin/macosx/big-sur-arm64/contrib/4.2/PACKAGES' Warning: unable to access index for repository https://bioconductor.org/packages/3.15/data/annotation/bin/macosx/big-sur-arm64/contrib/4.2: cannot open URL 'https://bioconductor.org/packages/3.15/data/annotation/bin/macosx/big-sur-arm64/contrib/4.2/PACKAGES' Warning: unable to access index for repository https://bioconductor.org/packages/3.15/data/experiment/bin/macosx/big-sur-arm64/contrib/4.2: cannot open URL 'https://bioconductor.org/packages/3.15/data/experiment/bin/macosx/big-sur-arm64/contrib/4.2/PACKAGES' Warning: unable to access index for repository https://bioconductor.org/packages/3.15/workflows/bin/macosx/big-sur-arm64/contrib/4.2: cannot open URL 'https://bioconductor.org/packages/3.15/workflows/bin/macosx/big-sur-arm64/contrib/4.2/PACKAGES' Warning: unable to access index for repository https://bioconductor.org/packages/3.15/books/bin/macosx/big-sur-arm64/contrib/4.2: cannot open URL 'https://bioconductor.org/packages/3.15/books/bin/macosx/big-sur-arm64/contrib/4.2/PACKAGES' Package which is only available in source form, and may need compilation of C/C++/Fortran: ‘msa’ Do you want to attempt to install these from sources? (Yes/no/cancel) Y installing the source package ‘msa’

trying URL 'https://bioconductor.org/packages/3.15/bioc/src/contrib/msa_1.28.0.tar.gz' Content type 'application/x-gzip' length 3885072 bytes (3.7 MB)

downloaded 3.7 MB

The downloaded source packages are in ‘/private/var/folders/6n/w8vt3k_d3t362slggmq9_qgc0000gn/T/RtmpU2YOox/downloaded_packages’ Warning message: In install.packages(...) : installation of package ‘msa’ had non-zero exit status

UBod commented 1 year ago

Thanks for reporting this issue, I am sorry that you encounter these difficulties! I have already looked into it and I will deal with this issue soon. However, I cannot make any promises when the issue will be fixed (I am short of time and I do not have a Mac platform to perform tests). It seems that the arm64 architecture will be supported also with pre-compiled binaries starting from BioC 3.16. So the issue will surely be dealt with and you will probably have a ready-made binary at the end of the day. Please stay tuned!

UBod commented 1 year ago

Maybe, in the meantime, you can have a look at this issue which seems related. Can you please try to use something like export CFLAGS=-DAO_GCC_FORCE_HAVE_CAS in the shell from which you run R to install 'msa'?

cnrakt commented 1 year ago

Hi Ubod,

I'm working on a new package depends on your msa package, I'm also using arm64 base, so I had the same problem as BC19RG. I can re-compile files for you if you don't have arm64 platform.

Best,

UBod commented 1 year ago

That's great, thanks, @cnrakt! I do not have any Mac computer to test my package, let alone an arm64. I will create a branch on this repo here and then ask you to test it. Ok? I can't tell precisely yet when I will have time. I'll keep you posted. Thanks again, Ulrich

cnrakt commented 1 year ago

Great! Happy to help 👍

Best, Caner

adippolito-kymeratx commented 1 year ago

For what it's worth, I ran into the same issue when trying to install msa this morning. Thanks for looking into this!

Doznkekz commented 1 year ago

For what it's worth, I ran into the same issue when trying to install msa this morning. Thanks for looking into this!

Me too

cnrakt commented 1 year ago

Hi,

Today I try to recompile latest source on apple silicon. I think this may help:

R CMD build msa

In file included from allchblk.c:17: ./include/private/gc_priv.h:2323:24: error: unknown type name 'AO_TS_t' GC_EXTERN volatile AO_TS_t GC_fault_handler_lock;

2 errors generated. make[3]: [allchblk.lo] Error 1 make[2]: [all-recursive] Error 1 make[1]: [build_gc] Error 2 make: [build_gc] Error 2 ERROR: compilation failed for package ‘msa’**

UBod commented 1 year ago

Thanks, @cnrakt! That's actually consistent with the output that @BC19RG posted earlier. The reason is the 'gc' garbage collector library (which is necessary to counteract the memory leaks in Muscle and ClustalOmega). I will have to update the 'gc' library to a newer version (the current one seems not to work with arm64). I hope I will have time to fix this within the next 2-3 weeks. Sorry for the delay, but I am currently very busy with other matters.

UBod commented 1 year ago

Hi Ubod,

I'm working on a new package depends on your msa package, I'm also using arm64 base, so I had the same problem as BC19RG. I can re-compile files for you if you don't have arm64 platform.

Best,

@cnrakt, you kindly offered to perform tests on an arm64 platform. I just pushed an update. Could you please try to pull it and try it on arm64? That would be very helpful, thanks a lot in advance!

cnrakt commented 1 year ago

That's great, it works! Installation has finished with some warnings. Thank you very much.

R console: msa_package_arm64_mac_installation_console.txt

BC19RG commented 1 year ago

Thank you very much. I have got it working.

Does not work!

install.packages("msa")

Does not work!

if (!requireNamespace("BiocManager", quietly=TRUE)) install.packages("BiocManager") BiocManager::install("msa")

WORKS :)

library(devtools) install_github("Ubod/msa") library(msa)

UBod commented 1 year ago

That's fantastic, @cnrakt and @BC19RG, thanks a lot for your help! I will push the new version to the BioC repo later today and close the issue once all checks run through.

UBod commented 1 year ago

By today, the binary builds for arm64 have completed successfully for msa (see here) and a binary has been built. Therefore, I am closing this issue. Thanks again to all wo helped me!