search

UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
13 stars 7 forks source link

Bug fix helix number was badly set in cadnano export #189

Closed tcosmo closed 3 years ago

tcosmo commented 3 years ago

https://github.com/UC-Davis-molecular-computing/scadnano-python-package/issues/185

tcosmo commented 3 years ago

@dave-doty it is fixed, it came from the messy situation that tests_inputs/cadnano_v2_export/ are gitignored because most of them are automatically generated but in the paranemic case, the test is not generated but to be read from a .sc file so it was failing because the file was not found.

tcosmo commented 3 years ago

@dave-doty I mistakenly did the pull request to main, should I move it to dev?

Also note that the tests for the import/export features are quite weak as they do not check, for example in the case of exporting to cadnano, that cadnano can actually read the file.

It results for instance in test 'TestExportCadnanoV2.test_export_design_with_helix_group' creating a file that cadnano cannot process.

dave-doty commented 3 years ago

@dave-doty I mistakenly did the pull request to main, should I move it to dev?

Good catch, yes please merge to dev instead of main.