search

UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
13 stars 7 forks source link

Oxdna export roll angle fix #190

Closed DanielHader closed 3 years ago

DanielHader commented 3 years ago

When applying the roll angle to a helix, the function _oxdna_get_helix_vectors was applying the roll angle in the wrong orientation (counterclockwise instead of clockwise). This fix simply flips the direction in which the roll is applied.

DanielHader commented 3 years ago

Can you add a commit that has the phrase "fixes #188", so that GitHub will automatically close the issue when this makes it to the main branch? (https://github.com/UC-Davis-molecular-computing/scadnano-python-package/blob/main/CONTRIBUTING.md#pushing-to-the-repository-dev-branch-and-documenting-changes-done-on-all-updates)

done!