search

UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
14 stars 7 forks source link

Create pull_request_template.md #195

Closed UnHumbleBen closed 3 years ago

UnHumbleBen commented 3 years ago

Description

Added a simple PR template. (Inspired by https://github.com/stevemao/github-issue-templates/blob/master/bugs-only/PULL_REQUEST_TEMPLATE.md)

Motivation and Context

Improve the code review process by providing a template for PR descriptions.

How Has This Been Tested?

Manually tested on my fork: https://github.com/UnHumbleBen/scadnano-python-package-1/compare/master...UnHumbleBen:dev

Verified the template is automatically pasted into the pull request body

Screenshots (if appropriate):

image

UnHumbleBen commented 3 years ago

Yup it’s automatic. Here’s a reference: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/creating-a-pull-request-template-for-your-repository

On Sun, Oct 17, 2021 at 9:44 AM David Doty @.***> wrote:

@.**** approved this pull request.

Looks good.

We talked about a way to have this automatically populate the PR description field. It says that this will happen, but I'm not sure how since the only change is to add this .md file. Is it based on convention? (similar to how README.md is the file automatically displayed on the GitHub page)

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/UC-Davis-molecular-computing/scadnano-python-package/pull/195#pullrequestreview-781469324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHOOY77QIJBDG53LRZI7IYLUHL4MVANCNFSM5GEI3BWQ .