search

UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
13 stars 7 forks source link

Fixes #205; make xlwt a dependency for pip installing #206

Closed UnHumbleBen closed 2 years ago

UnHumbleBen commented 2 years ago

Description

Moved 'xlwt' from requires to install_requires. Dependencies are supposed to be specified in install_requires. I couldn't find a clear reason why requires is not valid, but I do see in the setuptools keywords page that:

requires is superseded by install_requires and should not be used anymore.

Related Issue

205

Motivation and Context

Currently, xlwt is not installed when scadnano is installed using pip.

How Has This Been Tested?

Setup: Used new setup.py to make new PyPI test package: https://pypi.org/project/scadnano-test/

  1. Uninstall xlwt with pip uninstall xlwt
  2. Install scadnano-test pip install scadnano-test
  3. Open a python shell and ran import xlwt and verified no import error, so xlwt is installed