UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
13 stars 7 forks source link

crossover to same helix should be converted properly in cadnano import #209

Closed dave-doty closed 2 years ago

dave-doty commented 2 years ago

In cadnano 2, create a strand with two domains on the same helix and a "crossover" between them:

image

This should be representable in scadnano and show up like this:

image

Import this design into scadnano. Instead, it interprets the two domains and the crossover as one long domain:

image

This cadnano file represents the above simple design, to help reproduce this error.

tcosmo commented 2 years ago

@dave-doty @UnHumbleBen

I have solved this issue with this PR: https://github.com/UC-Davis-molecular-computing/scadnano-python-package/pull/214

It should not be complex to adapt in the Dart code as it was only the case to add one more case to the condition that decides whether or not to add a crossover (condition 2.) :

Screenshot 2022-02-01 at 17 54 02