UC-Davis-molecular-computing / scadnano-python-package

Python scripting library for generating designs readable by scadnano.
https://scadnano.org
MIT License
13 stars 7 forks source link

Helix order when importing from cadnano #217

Closed tcosmo closed 2 years ago

tcosmo commented 2 years ago

Description

Cadnano's helix order was not conserved when using from_cadnano_v2. That happened because @dave-doty thought that the constructor of Design would automatically handle this ordering (by correctly setting helices_view_order) but it does not. I have given more details in the related issue: https://github.com/UC-Davis-molecular-computing/scadnano-python-package/issues/202

In order to fix this bug I uncommented the following instruction which sets the helix order directly in the import code instead of relying on Design's constructor:

design.set_helices_view_order([num for num in helices]) l.4648

Related Issue

https://github.com/UC-Davis-molecular-computing/scadnano-python-package/issues/202

How Has This Been Tested?

I added the test tests.scadnano_tests.TestImportCadnanoV2.test_helices_order2