search

UC-Davis-molecular-computing / scadnano

Web application for designing DNA structures such as DNA origami.
https://scadnano.org
MIT License
21 stars 13 forks source link

add memoized selectors for each connected component #65

Open dave-doty opened 4 years ago

dave-doty commented 4 years ago

Based on this comment: https://github.com/Workiva/over_react/issues/434#issuecomment-567677175

It may be more performant to create a memoized selector for each connected component, which returns the Props map for that component. This way the exact same object will be returned (rather than a new Props map with the same values as the old one), which can be more immediately compared for equality.

dave-doty commented 4 years ago

Removing high-priority since I found a way to boost the performance by reducing the number of connected components: #87

But it still would be nice to see if this can be done, since having many deeply nested connected components is easier to maintain since the props don't need to be passed way down the view tree.