[song-directory-transpose] Decide which "qualities" should be ported upstream - Githubissues

UC3Music / songbook-tools

Tools for minimally markuped songs, like book generation and chord transposition

https://github.com/UC3Music/songbook-tools

The Unlicense

3 stars 0 forks source link

[song-directory-transpose] Decide which "qualities" should be ported upstream #13

Open jgvictores opened 7 years ago

jgvictores commented 7 years ago

Decide which "qualities" should be ported upstream

Source: this hackish line: https://github.com/UC3Music/songbook-tools/blob/d7c8543a5d9076ace21d0f6a63ae6e0530ca67c4/transpose-song-directory.py#L34
Destination: this upstream file
EDIT: Current source: https://github.com/UC3Music/songbook-tools/blob/3cfae1360f54149ffc31b101c7bc5443daaeba2c/song-directory-transpose.py#L38

jgvictores commented 6 years ago

Note that m7b5exists, just that it's called m7-5: https://github.com/yuma-m/pychord/blob/4a4578e7ba6bf2ffaa5c5cbacb3a5ba43ca24066/pychord/constants/qualities.py#L24

jgvictores commented 6 years ago

This just became an issue, because - was used as a delimiter.

jgvictores commented 6 years ago

Reverted e11eec5b619d85b9884362e374ced21cf372c2f8 with a forced push for now.

jgvictores commented 6 years ago

Blocked by #21, which should prevent previously stated fact.

jgvictores commented 6 years ago

Blocked by #21, which should prevent previously stated fact.

Which makes it no longer upstream.

jgvictores commented 6 years ago

Finally unblocked thanks to #21!!!

jgvictores commented 6 years ago

Note that some are already implemented, but as - instead of m, example 7-13, and are now possible without porting upstream.