search

UCA4SVR / TOUCAN-VR

Testbed Oriented to User-Centric Approach in Networking for Virtual Reality
Apache License 2.0
12 stars 5 forks source link

Fixed crash when re-launching the application #54

Closed wasp898 closed 7 years ago

wasp898 commented 7 years ago

If the phone keeps an instance of the app somewhere in memory, when launching the application the intent exists but it’s not the one provided by the parametrizer. So the app crashes because of null pointers, etc.

This happens when you launch the app, then you force-close it, and then you launch it again. It's a bug that needs to be fixed asap. Sorry about that.

On the other hand, the review process should be easy since I have only changed one line of code :)

wasp898 commented 7 years ago

Okay, I modified just as requested. Thanks!

savinoda commented 7 years ago

It can be merged for me. Waiting for @Endmaril

Endmaril commented 7 years ago

Seems to be ok now, the onResume is handled correctly. I made some changes to improve the way bandwidth logging and the bandwidth meter are managed upon receiving a new intent.

Everything is ok for me. Can you confirm @savinoda so that we can merge.

Thanks. Romaric

savinoda commented 7 years ago

Ok I'm going to check the code and try it again.

savinoda commented 7 years ago

I receive an error when trying to launch the VR application with a new intent; in particular, the application crashes because of an exception. Unable to resume activity java.util.ConcurrentModificationException

The function removeAllListeners() seems to cause the problem

savinoda commented 7 years ago

It seems to be ok now. I also tried to remove the permission manually and then it is correctly asked when the application is resumed.