Open mswiatlo opened 5 years ago
/cc @kkrizka ? I think the way he wrote it, cleverly, will just look at the "year" in the path to the file you're using in the config and filter things out for anything that's not appropriate to the year you're running on. So if you just pass them all in, it should filter things out... I think.
My guess is, that because the actualMu
are passed in as the PRW Config File and not the lumicalc file -- that this isn't being done correctly (which is kinda annoying b/c of PURW itself).
Hi all,
Looking at the file names of the actualMu
config files, it does not seem like we can infer the year (and hence the campaign) from it. (ei: physics_25ns_Triggerno17e33prim.actualMu.OflLumi-13TeV-001.root) .
I would propose we copy SUSYTools further and add m_prwActualMu201XFile
options for all years. Then use the determined mcCampaign
value to add the right one. I'll submit an MR shortly.
Regarding @mswiatlo's point 1, I don't think it will work. The PRW tool does not check the campaign of the MC being reweighted. So if we always add them, the PRW tool will try to reweight mc16a to the 2017 actual mu data profile.
-- Karol Krizka
Thanks!!
Hi,
Do we have any facility for prw autoconfig to properly add the relevant actualMu file? I see two options:
1) Pass in the actualMu files like the GRL/lumiCalc and just always add them. I'm not sure if this breaks MC16a but since the files just contain histograms like pileup_data_run_339205 presumably this won't break MC16a. 2) Do something like SUSYTools (https://gitlab.cern.ch/atlas/athena/blob/21.2/PhysicsAnalysis/SUSYPhys/SUSYTools/Root/SUSYObjDef_xAOD.cxx#L889) to add a configured actualMu upon detecting the right campaign.
Thoughts?
Best, Max