UCATLAS / xAODAnaHelpers

ATLAS Run 2 and Run 3 analysis framework for AnalysisTop and AnalysisBase for proton-smashing physics
https://ucatlas.github.io/xAODAnaHelpers/
Apache License 2.0
42 stars 127 forks source link

Updates to xAH for Trigger-Level Analyses from GitLab-hosted fork #1675

Closed mamerl closed 9 months ago

mamerl commented 9 months ago

Changes include:

mdhank commented 9 months ago

Hi @mamerl ,

It looks like this is starting from an old version of xAH- there are a lot of changes listed, and some of them (such as removing AF3 support) seem to be undoing updates that have been made in the meantime. Would it be possible to rebase this onto a more current version of xAH?

Best, Michael

mamerl commented 9 months ago

Hi @mdhank,

Thanks for pointing that out. I'm in the process of doing a rebase at the moment so will sort that out and mark this PR as a draft until I have done so.

Thanks, Max

mamerl commented 9 months ago

Hi @mdhank,

It appears that the rebase didn't work because of some issues with the history for our branch. I'll try to hunt through our commit history and start a new branch from the HEAD of main on my fork of xAODAnaHelpers then will patch the commits for our changes over.

In the meantime, I'll close this PR.

Thanks, Max

mamerl commented 9 months ago

For documentation purposes the updated MR is available at https://github.com/UCATLAS/xAODAnaHelpers/pull/1676