UCATLAS / xAODAnaHelpers

ATLAS Run 2 and Run 3 analysis framework for AnalysisTop and AnalysisBase for proton-smashing physics
https://ucatlas.github.io/xAODAnaHelpers/
Apache License 2.0
42 stars 127 forks source link

CMake warning for missing "pytools" when compiling xAH in AnalysisBase 24.2.41 #1678

Closed mamerl closed 9 months ago

mamerl commented 9 months ago

We are preparing to update our analysis framework to release 24 using the latest stable AnalysisBase release (24.2.41). After setting up the latest version of the xAODAnaHelpers main in our framework we encounter the following warning when compiling:

CMake Warning at xAODAnaHelpers/cmake/SetupPythonPackage.cmake:4 (find_package):
  By not providing "Findpytools.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "pytools", but
  CMake did not find one.

  Could not find a package configuration file provided by "pytools" with any
  of the following names:

    pytoolsConfig.cmake
    pytools-config.cmake

  Add the installation prefix of "pytools" to CMAKE_PREFIX_PATH or set
  "pytools_DIR" to a directory containing one of the above files.  If
  "pytools" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  xAODAnaHelpers/CMakeLists.txt:64 (include)

To obtain this warning we setup our environment as so: (required options for compiling Athena included since we have a sparse checkout of Athena in our framework)

setupATLAS
lsetup git
asetup Athena,24.2.41,here # from src directory
echo "- athena/Projects/.*" > package_filters.txt
cmake -DATLAS_PACKAGE_FILTER_FILE=package_filters.txt ../src # from build directory

I'm not sure if this warning is due to an environment issue in our setup or not, so just opening this issue for feedback and to discuss how to resolve the warning.

Tagging @mdhank and @tofitsch in case they have suggestions.

Thanks!

mdhank commented 9 months ago

Hi @mamerl,

Were you previously running an earlier version of AB where this did not occur? I've started to look into this, and it appears starting with AB 24.2.23. However, it might not be new as in 24.2.22, cmake gives

-- Could NOT find pytools (missing: _PYTOOLS_BINARY_PATH CHARDET_FOUND IDNA_FOUND URLLIB3_FOUND)

but doesn't label it a warning.

Best, Michael

mamerl commented 9 months ago

Hi @mdhank,

We were previously running with the Centos7 OS with AB release 22.2.113 and after checking the cmake output I also see:

-- Could NOT find pytools (missing: _PYTOOLS_PYTHON_PATH CHARDET_FOUND IDNA_FOUND URLLIB3_FOUND) 

Maybe the more visible warning when running with 24.2.41 is just an effect of differences in the dependency versions for EL9 w.r.t. Centos7 in that case, which is likely why we didn't see the warning above before?

Since we see this for the AB 22.2 as well, maybe it isn't a big problem.

Thanks, Max

mdhank commented 9 months ago

Hi @mamerl ,

I don't think this is specifically from EL9, as my tests were still on Centos7 and still showed it. I haven't pinpointed why, but the increased visibility does just seem to be an effect of moving to AB 24.2.23 or higher.

But if everything still runs the same as before then it probably isn't a big problem.

Best, Michael

mamerl commented 9 months ago

Hi @mdhank,

Great, thanks for the extra information and clarification.

I'll close this issue now.

Thanks, Max