Closed daniestevez closed 2 years ago
@daniestevez
It's amazing that nobody has reported this before!
Fixed as you suggested + a little cleanup in guppi.py
and rawhdr.py
.
Thanks! This can be closed whenever you want.
@daniestevez Note that you can close issues that you have opened once you are satisfied with a resolution.
I'm running Blimpy 2.0.11 under Python 3.7.6 and I have found that
GuppyFile.get_data()
raisesStopIteration
, which Python 3.7 will transform into aRuntimeError
. This will terminate the execution of the script unless theRuntimeError
is caught. This has to do with PEP 479, which was introduced in Python 3.7.This can be replicated using the example code
Such an example will give the following traceback:
In PEP 479 it is stated that
Therefore, I think that using
return
instead ofStopIteration
inGuppyFile.get_data()
would fix this problem, but I'm not 100% how this interacts with Python 2.7. If you think this is a good solution, I can submit a PR with the change.