search

UCBerkeleySETI / hyperseti

A SETI / technosignature search code to find intelligent life beyond Earth
https://hyperseti.readthedocs.io
11 stars 4 forks source link

test_hyperseti passing wrong data shape to dedoppler() #18

Closed texadactyl closed 3 years ago

texadactyl commented 3 years ago

hyperseti/hyperseti.py:223: N_time, N_beam, N_chan = data.shape

but

test_hyperseti.py test_data = np.ones(shape=(32, 1024)) # line 18

Symptoms in pytest: E ValueError: not enough values to unpack (expected 3, got 2)

texadactyl commented 3 years ago

There are quite a few assumptions of (time, frequency) all over test_hyperseti.py; the code should be assuming (time, beam, frequency). This needs to be addressed asap.

I am starting a PR which I hope addresses this partially. Included in the PR is a proposed reorganisation of the repo.