@chrisorwa I noticed that summary.pop_data() was producing incorrect results in your add-group_by-option-to-summary branch (see before/after screenshots below), so I went in and corrected it. Please review my changes line-by-line as well as the GitHub comments that I wrote, explaining some of the details.
Going forward, please use the "snapshot" system for testing functions with complicated outputs: https://r-pkgs.org/testing-basics.html#sec-snapshot-tests
@chrisorwa I noticed that
summary.pop_data()was producing incorrect results in youradd-group_by-option-to-summarybranch (see before/after screenshots below), so I went in and corrected it. Please review my changes line-by-line as well as the GitHub comments that I wrote, explaining some of the details. Going forward, please use the "snapshot" system for testing functions with complicated outputs: https://r-pkgs.org/testing-basics.html#sec-snapshot-tests