improving `check_pop_data()`

UCD-SERG / serocalculator

Estimating Infection Rates from Serological Data

https://ucd-serg.github.io/serocalculator/

4 stars 2 forks source link

improving `check_pop_data()` #207

Closed d-morrison closed 4 months ago

d-morrison commented 4 months ago

improving error messages, added test

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Files	Coverage Δ
R/check_pop_data.R	`100.00% <100.00%> (+53.84%)`	:arrow_up:

d-morrison commented 4 months ago

Looks good! How do we communicate the error classes available in the package?

@chrisorwa good question; I'm still coming up to speed on error classes, but as far as I can tell, they are not part of the API - we create them ourselves for our own internal use in unit tests, instead of using the regexp argument for testthat::expect_error(). So there won't be an exhaustive list; they are more like the inputId arguments in Shiny inputs. Take a look here for more information.