search

UCDavisLibrary / ava

American Viticultural Areas
https://ucdavislibrary.github.io/ava/
Creative Commons Zero v1.0 Universal
62 stars 56 forks source link

New version of ScrapeRevisiopnHistories_new.R #842

Closed erklopez closed 2 years ago

erklopez commented 2 years ago

Should fix most of the problems discussed in issue #841.

MicheleTobias commented 2 years ago

I'm getting an error running the code on line 77. I believe it's caused by line 73 - the path in my environment is set to ~/GitHub/ava/rcode, so the path in line 73 doesn't work. If you change the path to start with two dots .. it works.

Let's output the files somewhere else. The avas_aggregated folder is specifically for data for people to download. Maybe we need a reports folder or something like that to hold these kinds of reports.

MicheleTobias commented 2 years ago

Per our discussion last week, I'm going to merge this PR, but expect that there may be some additional work on this file later.