UCDavisLibrary / ava

American Viticultural Areas
https://ucdavislibrary.github.io/ava/
Creative Commons Zero v1.0 Universal
62 stars 56 forks source link

Add revision for Clear Lake #879

Closed kurtishouser closed 2 years ago

kurtishouser commented 2 years ago

The PR add the latest revision for Clear Lake. See #861.

Attributes for the initial AVA feature were checked.

I also made a few corrections to Upper Lake Valley.

QGIS project is on my Google Drive. Unzip map files before opening the project.

Map files used:

Clear Lake
CA_ClearlakeOaks_297115_1960_62500_geo_tif
CA_Kelseyville_297873_1959_62500_geo_tif
CA_Lakeport_297948_1958_62500_geo_tif
CA_LowerLake_298073_1958_62500_geo_tif
CA_UpperLake_102101_1996_24000_geo_tif

Upper Lake Valley
CA_BartlettMountain_100104_1996_24000_geo_tif
CA_Lakeport_292105_1958_24000_geo_tif
CA_Lucerne_292619_1996_24000_geo_tif
CA_UpperLake_102101_1996_24000_geo_tif
MicheleTobias commented 2 years ago

Thanks, Kurtis! Just so you know what's going on - when my students are back next week (we're on the quarter system at UC Davis so we start mid-September), they're going to learn how to review pull requests. I wanted you to know that I know your work is here and ready to review, but it might take a week or so before the team is up to speed on that process.

kurtishouser commented 2 years ago

No rush, thanks for the update. I have all my PRs merged into a separate branch on my local machine so I could get the data imported into a database and move forward with my project.

I think it would be helpful if your team could develop a process that utilizes a file diff tool to compare the current and updated files, nicely formatted, next to each other. It's much easier to see specific changes and spot potential errors this way. It's hard to do with the QGIS output and the GitHub file diff.