search

UCDavisLibrary / ava

American Viticultural Areas
https://ucdavislibrary.github.io/ava/
Creative Commons Zero v1.0 Universal
62 stars 56 forks source link

Fix valid start & valid end column formats #904

Closed alisonsnwong closed 1 year ago

alisonsnwong commented 1 year ago

https://github.com/UCDavisLibrary/ava/issues/845

Fixed the valid start & valid end column formats bug.

MicheleTobias commented 1 year ago

This is an excellent start and you've almost solved the issue. Here are some refinements I'd like you to implement:

  1. The date format should match the definitions we put in the documentation.
  2. The area column needs to be removed. We use that to order the stacking of the polygons (small polygons on top) so we can see all of them, but we don't need to give that to the users. They should calculate their own area in the projection of their choice.
alisonsnwong commented 1 year ago

I updated the file so that it is in date format and removed the area column. The removed column is still listed as a string type in QGIS because I believe they are all NULL values but if there is a date added in one of the attributes in the future, it would become the date type like listed in R.