search

UCDavisLibrary / ava

American Viticultural Areas
https://ucdavislibrary.github.io/ava/
Creative Commons Zero v1.0 Universal
62 stars 56 forks source link

corrected minor bug, deals with eCFR making blank sections or section… #915

Closed erklopez closed 1 year ago

erklopez commented 1 year ago

…s with less than 4 characters and create a data frame called error_sections, which can be double checked in case of having a valid ava with a name shorter than 4 characters.

kurtishouser commented 1 year ago

Whenever I get an email notification from ecfr.gov that there has been a change to the new eCFR site, sometimes the names of the recently approved AVAs are listed as xxx. It appears that this happens when the approval document gets filed before the effective date of the AVA. It's odd but it gets resolved with the next update. I haven't seen anything other than xxx so perhaps it would be better to look for this instead using the length?

erklopez commented 1 year ago

Whenever I get an email notification from ecfr.gov that there has been a change to the new eCFR site, sometimes the names of the recently approved AVAs are listed as xxx. It appears that this happens when the approval document gets filed before the effective date of the AVA. It's odd but it gets resolved with the next update. I haven't seen anything other than xxx so perhaps it would be better to look for this instead using the length?

I wasn't sure if this was a recurring case, thank you for the input @kurtishouser.