UCDavisLibrary / fin-server

Fedora backed UC Davis Library DAMS Server
MIT License
5 stars 0 forks source link

Video: Radio buttons stay selected after making new selection #202

Closed wrenaria closed 4 years ago

wrenaria commented 4 years ago

Radio buttons stay selected after changing videos options for speed and captions. This happens on all browsers and devices.

Screen Shot 2020-02-12 at 3 37 35 PM

Screen Shot 2020-02-12 at 3 37 49 PM

wrenaria commented 4 years ago

In the captions settings, is the "Shaka Player TextTrack" option supposed to do anything (like show captions)?

wrenaria commented 4 years ago

Seems like this is still buggy. Sometimes when I open Settings on a video, it's already in a specific area (like Speed). Settings should always open to top level of settings by default. There were also a couple times Speed would have both the 1.0 and 1.75 (this happened on Safari and Chrome), but the experience was inconsistent.

Screen Shot 2020-02-14 at 10 01 21 AM

wrenaria commented 4 years ago

Okay, after more experimenting I -think- what's happening with the radio buttons here is if you make a selection on a different video (like change the speed to 4x) and then go find a different video, the radio button for the selection on the last video you watched remains selected along with the default option (so both are selected).

jrmerz commented 4 years ago

@wrenaria @qjhart So have made some progress in fixing plyr to support webcomponents. However upon further review there was still major issues with keyboard navigation in the popup menu when used in shadow dom. These issues seemed extensive and I was not able to track down after a couple hours of investigation.

I am proposing (and code deployed above implements this) that we ditch the settings menu. Just play/pause, volume slider, sound slider with mute. This will let use get on track for deployment and we can revisit when we have time to truly test out plyr as a webcomponent.

wrenaria commented 4 years ago

Fine by me!

jrmerz commented 4 years ago

All changes deployed to next