UCDavisLibrary / ucdlib-theme-wp

Wordpress theme port of the UC Davis SiteFarm One Theme
2 stars 0 forks source link

fancy heading has lag #127

Closed spelkey-ucd closed 2 years ago

spelkey-ucd commented 2 years ago

When loading/selecting the fancy heading block it lags for a couple seconds.

Seems to be caused by loading so many custom alt styles, which each have a preview. To fix, need to move the alt styles to a normal text-based dropdown.

wrenaria commented 2 years ago

I checked out your solution on sandbox. This works for me, but I'd like to call out the colors next to more of the heading names to help people out:

Also I no longer see the option for bolding the "underlined and weighted" titles that use to be there? Come to think of it, do we need two style options for weighted/not weighted? Couldn't people just choose to not bold things on the weighted option?

spelkey-ucd commented 2 years ago

ahhhh right you are. bold option is back.

For the weighting, you are also right. Now weighting is solely controlled by the toolbar formatting button. It is enabled as an option for the "underline" and "weighted". I renamed "weighted" to "Not Underlined" since it is exactly the same as underline but without the yellow dots... Let me know if it should be named something different.

https://sandbox.library.ucdavis.edu/headerz/

wrenaria commented 2 years ago

@spelkey-ucd This looks good! Ready for stage.

spelkey-ucd commented 2 years ago

fyi, this appears to have been fixed in the most recent version of wp. dont need to undo this work, i think. but dont need to worry about this problem cropping up for future block development