search

UCF / Athena-Framework

A front-end web framework for UCF websites and applications
https://ucf.github.io/Athena-Framework/
MIT License
3 stars 1 forks source link

Navbars without a .navbar-toggleable class (always collapse/show toggle btn) don't show divider when expanded #68

Open cjg89 opened 7 years ago

cjg89 commented 7 years ago

Because the border-top on .navbar-collapse, when expanded, is dependent on the parent navbar having the .navbar-toggleable class assigned to it (https://github.com/UCF/Athena-Framework/blob/master/src/scss/_navbar.scss#L324-L328), navbars without a .navbar-toggleable class won't have a divider when expanded.

With .navbar-toggleable-lg class (works): screen shot 2017-06-01 at 11 10 04 am

With no .navbar-toggleable class (fails): screen shot 2017-06-01 at 11 09 46 am

cjg89 commented 7 years ago

Pushing this back to v1.0.0-beta.1. Bootstrap's alpha.6 version of the navbars intended on the .navbar-toggleable- class to be required for all navbars, but the updated code from their v4-dev branch that we've integrated does not require it (and has also renamed it and made the logic behind it more mobile-first).

cjg89 commented 7 years ago

Part of fixing this issue goes back to needing to merge in the latest Bootstrap 4 beta code that makes navbars mobile/collapsed-first, and transitioning the .navbar-toggleable class to .navbar-expand. Without the updated code, we'll basically need to rewrite navbars ourselves and make sure we apply all the overrides necessary to the existing Bootstrap alpha navbar styles. This is doable, except for some issues I'm having with IE 10/11--the short of it is, every fix I make seems to break something else... so, I'm putting this on hold for now.

See #88