search

UCF / Theme-Updater

A theme updater for GitHub hosted Wordpress themes. This Wordpress plugin automatically checks GitHub for theme updates and enables automatic install.
107 stars 35 forks source link

notices for depricated function #24

Open scarstens opened 12 years ago

scarstens commented 12 years ago

Notice: get_themes is deprecated since version 3.4! Use wp_get_themes() instead. in /public_html/wlwp.sethmatics.com/wp-includes/functions.php on line 2628

I highly suggest you turn on debug mode and click through the WordPress admin. Still some issues hanging around in there. Now that you have updated the plugin I'm going to take a second look at integrating a "more full" version of what you have but simply activating the plugin gives me errors (notices that cause problems while developing).

conover commented 12 years ago

I meant to change this in the last update but forgot. I'll update the plugin when I get a chance.

scarstens commented 12 years ago

I just set this on line 24: $installed_themes = wp_get_themes( );

doesn't appear to break anything thankfully. should be an easy "fix". I'm reading through the foreach right now where you (or somebody) commented on refactoring the whole thing. Is there something specific you wanted to do here? I've forked the plugin so I'll likely have some pull requests for you if your willing to consider them. I'm also looking into the renaming issue right now.

conover commented 12 years ago

It's a little more complicated because I want to maintain backwards compatibility with versions of WordPress older than 3.4.0 (when wp_get_themes became officially available).

scarstens commented 12 years ago

if(function_exists('wp_get_themes')) $installed_themes = wp_get_themes( ); else $installed_themes = get_themes( );