search

UCHIC / ODM2Sensor

A Python-Django web application for water-related sensor infrastructure and data management.
BSD 3-Clause "New" or "Revised" License
7 stars 3 forks source link

Altering Set up site visit to safely manage data. #282

Open Elijahwalkerwest opened 6 years ago

Elijahwalkerwest commented 6 years ago

Currently when you update or create a site visit, it deletes the data before re-creating it from the request. This is really bad data management.

This causes data to be deleted if for some reason it can't create the new object. Big problem.

So I am updating this view to manage data more responsibly.

AmberSJones commented 6 years ago

I'm not sure how to test this. @Elijahwalkerwest , you can give me some steps to walk through, or if you are convinced that it is addressed (by doing some testing of your own), you can close it.

AmberSJones commented 6 years ago

@Elijahwalkerwest ditto the previous comment.

Elijahwalkerwest commented 6 years ago

Testing this involves intentionally breaking some code. I.E. making sure that if different parts of editing/creating site visits break, it doesn't break data. I'm testing this myself, I'll update and close when I feel more confident.