UCHIC / WEBTSA

A web application for visualizing time series of environmental observations.
BSD 3-Clause "New" or "Revised" License
3 stars 2 forks source link

Handling -9999 Values #109

Closed AmberSJones closed 6 years ago

AmberSJones commented 6 years ago

Have we discussed how to handle -9999 values in the TSA plotting? I'm of the opinion that we should ignore these values for plotting as displaying them washes out all other data. Since users cannot zoom in the y-axis direction, there is no way to view the actual data. Thoughts? @Maurier @horsburgh

image

horsburgh commented 6 years ago

Yes - no data values should be filtered out prior to plotting.

AmberSJones commented 6 years ago

@Maurier will you address this?

Maurier commented 6 years ago

Yes, could you point me to a dataset containing these values?

Maurier commented 6 years ago

Nevermind. I got it from the screenshot. I'll look into it.

Maurier commented 6 years ago

@AmberSJones, @horsburgh logic to filter out no data values has been in place. However, these datasets do not have this field populated. Should we assume a default of -9999 when this definition is absent in the dataset?

horsburgh commented 6 years ago

None of the datasets have changed. The TSA is still accessing the same data it was accessing before, it's just now accessing the data from Kenny's InfluxDB cache of the data. So, somewhere the NoData values have gotten lost in the new implementation.

@Maurier - where do you look for the NoData value? Should it be in the catalog?

@fryarludwig - Any ideas why the NoData values are missing?

Maurier commented 6 years ago

I discussed this with Juan. It seems it was removed recently, but we'll work on putting it back in the catalog.

fryarludwig commented 6 years ago

The NoData values were parsed from the WaterML when loading up the plot, and Influx doesn't carry this data. I've added the NoData values to the database and webtsa-utilities, now we just need to update the front end.

AmberSJones commented 6 years ago

Just checking in on this issue - are we waiting for @Maurier to make the connection with the front end?

Maurier commented 6 years ago

Yes, I should have a fix deployed today.

fryarludwig commented 6 years ago

Fixes are deployed to iUTAH and EnviroDIY production servers

AmberSJones commented 6 years ago

This is addressed. Thanks, all.