search

UCHIC / iUTAHData

The iUTAH Modeling and Data Federation website - data.iutahepscor.org.
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Photos Scrolling with the arrow keys #101

Closed AmberSJones closed 7 years ago

AmberSJones commented 7 years ago

Now there is weirdness when scrolling with the arrow keys. It seems to be stuck in a loop of the photos visible on the page or perhaps the photos that have been viewed already.

fryarludwig commented 7 years ago

When I reversed the scroll direction, I forgot to update the class names of the next/prev page buttons, which are used by the arrow keys when they reach the first or last thumbnails in the overlay. This has been fixed, and was the main cause of this issue.

An additional issue I found while looking into this also allowed for a "loop" of sorts - when scrolling rapidly through the images, requests would return more slowly than they were made - allowing for pages to load out of order. I've added semaphore-like behavior that prevents the page from "scrolling" before receiving the expected response.

AmberSJones commented 7 years ago

Looks good now. Closing.