search

UCL-ARC / python-tooling

Python package template for new research software projects
http://github-pages.arc.ucl.ac.uk/python-tooling/
MIT License
43 stars 2 forks source link

Exclude gnu.org and fsf.org from link checker #454

Closed samcunliffe closed 1 month ago

samcunliffe commented 1 month ago

The link checker is timing out at gnu.org and fsf.org. Propose to exclude as this is not the first time we've encountered this. And we can't remove the links: it's part of the licenses.

Would unblock @renovate bot's many updates.

paddyroddy commented 1 month ago

@samcunliffe stop automerging like that! Otherwise, what is the point in reviewing?

samcunliffe commented 1 month ago

@samcunliffe stop automerging like that! Otherwise, what is the point in reviewing?

🤖 the automerge robot and our linters are happy with my linebreaks.

paddyroddy commented 1 month ago

🤖 the automerge robot and our linters are happy with my linebreaks.

That's because you wouldn't allow https://prettier.io/docs/en/options.html#prose-wrap

samcunliffe commented 1 month ago

Did I? That doesn't sound like a think I would block...

We had it in

samcunliffe commented 1 month ago

🤖 the automerge robot and our linters are happy with my linebreaks.

That's because you wouldn't allow https://prettier.io/docs/en/options.html#prose-wrap

Ha! Found it. @paddyroddy, I'm sorry to report that it was you that removed that:

paddyroddy commented 1 month ago

Ha! Found it. @paddyroddy, I'm sorry to report that it was you that removed that:

* [Fix #361 #364](https://github.com/UCL-ARC/python-tooling/pull/364)

I'm fully aware, it was due to your markdown linking