UCL-INGI / ictm-teaching

A small app to help distribute courses among teaching assistants
0 stars 1 forks source link

Meeting 15 may copy #5

Closed SamuelVch98 closed 3 months ago

SamuelVch98 commented 4 months ago
anthonygego commented 3 months ago

Those minor comments should be fixed quickly. Please fix them as soon as possible so that we can merge and be able to read the next PRs diffs correctly. Maybe you will need to rebase them once this one is merged.

SamuelVch98 commented 3 months ago

These are the last comments after code testing. There are no length specified for the strings in the models: what DBMS are you using ? Ideally, we would like to rely on MySQL/MariaDB .

I use PostgreSQL but it's true that I should add a size limit for strings. Should I make the change straight away or can I add it in another PR?

anthonygego commented 3 months ago

LGTM. Please rebase the next PRs to master. Thanks