search

UCL-MIRSG / ansible-collection-infra

Ansible Collection to configure infrastructure for XNAT and OMERO
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Use FQCN for builtin module actions (ansible.builtin.yum) #110

Open paddyroddy opened 1 month ago

paddyroddy commented 1 month ago

Short Description

There seems to have been a recent Ansible lint change which recommends to: Useansible.builtin.dnforansible.legacy.dnfinstead

Evidence/Steps to Reproduce

No response

Acceptance Criteria/Expected Behaviour

No response

Details

No response

Resolution

For now I've added to .ansible-lint

p-j-smith commented 3 weeks ago

I think this is because yum is deprecated (and removed on latest versions of RHEL). ansible.builtin.yum uses yum on RHEL<8 and dnf otherwise. It looks like ansible.builtin.dnf will do the same, so we should be able to switch without any issues

paddyroddy commented 3 weeks ago

@p-j-smith it's not as trivial as it seems. I tried this, and it was giving me warning about picking dnf4 or dnf5 which I wasn't too sure on. Then on top of this, we have a lot of hardcoded variables with yum in their title. Plus, things like rpm URLs may have changed.

p-j-smith commented 3 weeks ago

ah I see, sounds like a lot more work then 😞