search

UCL-MIRSG / ansible-collection-infra

Ansible Collection to configure infrastructure for XNAT and OMERO
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Remove reusable workflow across molecule tests #116

Closed paddyroddy closed 1 month ago

paddyroddy commented 1 month ago

In the process of fixing things around #115, we want to use different options in the composite action related to https://github.com/UCL-MIRSG/.github/pull/121 & https://github.com/UCL-MIRSG/.github/pull/122. This would mean we'd need to set extra options in the reusable workflow, which will get confusing. By removing the reusable workflow, this will simplify things greatly. This will lead to more verbose code, but better in the long-term.

paddyroddy commented 1 month ago

@drmatthews and I worked on this one, so doesn't make sense that we review

paddyroddy commented 1 month ago

See comment in #115 (comment) about pinning to major version of Ansible instead.

Additionally, could we specify the ansible_version in a repo or org wide variable? And then when we want to move to Ansible 10.x.x we'd only need to change in one place?

Nice idea, incoming

paddyroddy commented 1 month ago

I have updated the actions to use the major Ansible version. If actions pass, then assume this is good to go.

paddyroddy commented 1 month ago

@HChughtai the ones that are failing are due to the whole paths: mess and me updating manually pip install ansible==${{ vars.ANSIBLE_MAJOR_VERSION }}.* so they can be ignored