search

UCL-MIRSG / ansible-collection-infra

Ansible Collection to configure infrastructure for XNAT and OMERO
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Review nginx port variables #65

Closed drmatthews closed 4 months ago

drmatthews commented 9 months ago

Short Description

Currently there are two variables referring to upstream ports that are a little confusing:

https://github.com/UCL-MIRSG/ansible-collection-infra/blob/370891833ae00d7bfd46ba0d18ea5c416e810b95/roles/nginx/templates/nginx_reverse_proxy.j2#L14-L23

We should have a look to see if both are needed and if they are we should think of more descriptive names.

Acceptance Criteria

No response

Dependencies

No response

Details

No response

p-j-smith commented 8 months ago

Yeah I find them confusing too. The previous variable names were:

stream {
    upstream dicom {
        server localhost:{{ xnat_dicom_port }};
    }

    server {
        listen {{ dicom_port }};
        proxy_pass dicom;
    }
}
HChughtai commented 4 months ago

Deprecated due to #126