search

UCL-RITS / doctoral-programming-intro

http://rits.github-pages.ucl.ac.uk/doctoral-programming-intro/
Creative Commons Attribution 4.0 International
8 stars 5 forks source link

Include exemplar data in distribution zip #45

Closed ageorgou closed 2 years ago

ageorgou commented 2 years ago

For #43, although does not address the question of whether the directory should be removed with make clean.

Have checked locally that this adds the files in the zip with no other apparent differences.

matt-graham commented 2 years ago

With regards to make clean removing the data subdirectory, it looks like this was originally added by James H prior to @edlowther updating the exemplar notebook (with just a subsequent change by @dpshelio to adjust for changed directory structure) so I suspect it can (and should) be removed.

ageorgou commented 2 years ago

Is that better dealt with in a separate PR? I noticed there's another CSV file produced from running the notebooks that is not cleaned (I guess a more recent addition) so perhaps better tackled together. But I can make the change for the data/ directory here too if preferable.

matt-graham commented 2 years ago

Is that better dealt with in a separate PR? I noticed there's another CSV file produced from running the notebooks that is not cleaned (I guess a more recent addition) so perhaps better tackled together. But I can make the change for the data/ directory here too if preferable.

Yeah I think we can probably do that in a separate PR and make sure we're removing all the generated artefacts / not removing anything else we don't want to! Happy for this to be merged.