UCL-RITS / rse-classwork-2020

3 stars 112 forks source link

Learning all about Pull Requests #4

Open dpshelio opened 4 years ago

dpshelio commented 4 years ago

In small groups:

  1. Fork my Travel guide repository
  2. Clone your fork locally
  3. Create a new branch named with a combination of your team e.g., dpshelio-ageorgou
  4. Create a new file in the right place named after a place both of you would like to visit. Create any intermediate directory needed. e.g., ./europe/spain/canary_islands.md
  5. Add to that file:
    • a title (e.g., # Canary Islands)
    • a small paragraph why you would like to go there
    • End the file with a link to wikivoyage and/or wikipedia of that place. e.g., More info at [wikivoyage](https://en.wikivoyage.org/wiki/Canary_Islands) and [wikipedia](https://en.wikipedia.org/wiki/Canary_islands)
  6. Commit that to your branch! (with a meaningful message)
  7. Add the internal links needed to get from the main page to that one e.g., link from Europe's README.md to Spain's README.md, link from Spain's README.md to Canary Islands file canary_island.md
  8. Commit these changes! (with a meaningful message)
  9. Create a pull request from your branch to my repository. Add a meaningful title to that PR and don't forget to mention your partner in the description (as @username and a link to this issue
    Answers UCL-RITS/rse-classwork-2020#4
goldsmdn commented 4 years ago

Pull Request to add Vendee dpshelio/Travel-guide#16 Added new files for France and the Vendee.