search

UCL-VR / ubiq

Other
98 stars 34 forks source link

Packaging errors #53

Closed sebjf closed 3 months ago

sebjf commented 3 months ago

The version at https://github.com/UCL-VR/ubiq.git#upm has a number of packaging errors out of the box, which are serious enough to prevent compilation or attaching a debugger.

2023.2.0b9

This is a known bug in Unity that means the 'VisionOS' option is not available in some versions despite being released in 2022. This causes problems for the null voip asmdef which prevents compilation of projects outside very specific versions.

2021.3.38 LTS

The latter is because Ubiq now relies on shadegraph 14, whereas <2022 versions of Unity have 12 inbuilt. Ubiq core should probably not rely on shadergraph at all.

2022.3.18 works OK.

bnco-dev commented 3 months ago

Shadergraph will have to stay; it's how we make the samples compatible with URP and builtin. I'll do some testing and try to find a version which works in 2021.3, 2022.3 and 6.

About the platform names: That's an annoying Unity bug! Seems like better behaviour would be to ignore the unknown platform names rather than to block compilation. But we can probably work around it by rejigging the VOIP asmdefs.

bnco-dev commented 3 months ago

Tested working with 2021.3.22f1, 2022.3.0f1, 2022.3.32f1, 6000.0.0f1.

Note versions of 2021.3 earlier than 22f1 do not work due to an issue with the Unity WebRTC package. Unity fixed this in 22f1. Suggest it's not worth our time to fix. Works well in versions 22 and later, so I've updated the readme to the effect that it's now our minimum supported editor version.