timlevine
commented
6 years ago To me this looks good. There is still an issue with the darkest colours being too dark for dark grey writing to show up
Can remove the decimal places of the % pSS - round to the nearest % point!
Also For Pfam, can ignore the information after the "." - that is just a version control thing (you could check that with Asif)
Both of these will make the thing look less messy where there are many short hits. You could also reduce the font size a bit!
From: Ilektra Christidi notifications@github.com Sent: Friday, January 5, 2018 10:52 AM To: UCL/HHyeast-server Cc: Levine, Tim; Mention Subject: [UCL/HHyeast-server] Compact view (#30)
Compact view is a bit messy: [bokeh_plot_compact]https://user-images.githubusercontent.com/22891967/34606120-070d1374-f206-11e7-8046-012a613f9e06.png
[https://user-images.githubusercontent.com/22891967/34606120-070d1374-f206-11e7-8046-012a613f9e06.png]
Moving the labels to the centre of the hit improved it somewhat, but didn't solve it... @timlevinehttps://github.com/timlevine , are you ok with it? Can we reduce the information on the label? Remember we can put it back in the text appearing when the cursor is over the hit.
You can view, comment on, or merge this pull request online at:
https://github.com/UCL/HHyeast-server/pull/30
Commit Summary
- Data squashing approach 1: doesn't work...
- Data squashing approach 2 works: loop over y positions instead of hits.
- Fix plot y-limits after squashing.
- Some aesthetic improvements:
File Changes
- M dataProcessing.pyhttps://github.com/UCL/HHyeast-server/pull/30/files#diff-0 (26)
- M lolliplotServerDetail.pyhttps://github.com/UCL/HHyeast-server/pull/30/files#diff-1 (2)
Patch Links:
- https://github.com/UCL/HHyeast-server/pull/30.patch
- https://github.com/UCL/HHyeast-server/pull/30.diff
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/UCL/HHyeast-server/pull/30, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM5sGFKJ-N3ZCDWJyN-TLWFMRHmmBmBtks5tHf8LgaJpZM4RUTMN.
ilectra
Fixes #7
Compact view is a bit messy:
Moving the labels to the centre of the hit improved it somewhat, but didn't solve it... @timlevine , are you ok with it? Can we reduce the information on the label? Remember we can put it back in the text appearing when the cursor is over the hit.