Open KrisThielemans opened 7 years ago
find_bin_given_cartesian_coordinates_of_detection (replace with get_bin(LOR&)). Used in
get_bin_for_gantry_coordinate_pair
. Should this still be replaced?find_scanner_coordinates_given_cartesian_coordinates (replace with get_LOR or get_LOR_as_2_points). Used in
get_det_pair_for_gantry_coordinate_pair
. Should this still be replaced?find_cartesian_coordinates_of_detection (replace with get_LOR or get_LOR_as_2_points). Used in
get_bin_detector_locations_in_gantry_coordinates
. Should this still be replaced?find_cartesian_coordinates_given_scanner_coordinates (replace with get_LOR or get_LOR_as_2_points). Used in
get_det_pair_locations_in_gantry_coordinates
. Should this still be replaced?
There's overlap between old and new (safer) functions. We should get rid of the old ones. Let's try to document here what needs to be done.
Functions that handle only rings or only tang_pos/view (these should become either private or protected)
[ ]
get_det_num_pair_for_view_tangential_pos_num
(replace withget_det_pos_pair_for_bin
). Used in a few places includingProjMatrixByBinUsingRayTracing
and some normalisation code.[ ]
get_view_tangential_pos_num_for_det_num_pair
(make private). Used inget_bin_for_det_pair
[ ]
get_segment_axial_pos_num_for_ring_pair
(make private?)CListEventCylindricalScannerWithViewTangRingRingEncoding
(used there to save some computation)get_bin_for_det_pair
[ ]
get_num_ring_pairs_for_segment_axial_pos_num
(useget_num_det_pos_pairs_for_bin
). Used inLmToProjData::get_compression_count
get_num_det_pos_pairs_for_bin
[ ]
get_ring_pair_for_segment_axial_pos_num
(make protected). Used inget_det_pair_for_bin
[ ]
get_all_ring_pairs_for_segment_axial_pos_num
(make protected). Used inget_all_det_pos_pairs_for_bin
Functions that use 4 coordinates (these should be removed)
[X]
get_bin_for_det_pair
(replace withget_bin_for_det_pos_pair
). Madeprivate
in https://github.com/NikEfth/STIR/pull/63 and hence https://github.com/UCL/STIR/pull/304[ ]
find_bin_given_cartesian_coordinates_of_detection
(replace withget_bin(LOR&)
). Used insrc/utilities/list_detector_and_bin_info.cxx
(but in comment)[ ]
find_scanner_coordinates_given_cartesian_coordinates
(replace withget_LOR
orget_LOR_as_2_points
). Used infind_bin_given_cartesian_coordinates_of_detection
[ ]
get_det_pair_for_bin
(replace withget_det_pos_pair_for_bin
). Used infind_cartesian_coordinates_of_detection
get_det_pos_pair_for_bin
construct_randoms_from_singles.cxx
MLnorm.cxx
[ ]
find_cartesian_coordinates_of_detection
(replace withget_LOR
orget_LOR_as_2_points
). Used inScatterEstimationByBin::find_detectors
[ ]
find_cartesian_coordinates_given_scanner_coordinates_of_the_front_surface
. This is not used.[ ]
find_cartesian_coordinates_given_scanner_coordinates
(replace withget_LOR
orget_LOR_as_2_points
). Used inCListEventCylindricalScannerWithDiscreteDetectors::get_LOR
find_cartesian_coordinates_of_detection
Of course, many of these are also used in
test_proj_data_info.cxx