Force use_actual_detector_boundaries to true for BlocksOnCylindrical

[markus-jehl]

Changes in this pull request

Forced use_actual_detector_boundaries to true for BlocksOnCylindrical (in set_up).

Testing performed

Unit tests.

Related issues

Fixes https://github.com/UCL/STIR/issues/1428

Checklist before requesting a review

• [] I have performed a self-review of my code
• [] I have added docstrings/doxygen in line with the guidance in the developer guide
• [] I have implemented unit tests that cover any new or modified functionality (if applicable)
• [] The code builds and runs on my machine
• [] documentation/release_XXX.md has been updated with any functionality change (if applicable)

[robbietuk]

This doesn't allow for a user to turn the detector boundaries off in a parameter file for blocks on cylindrical.

Using the boundaries can lead to ring artifacts around the boarder too. It should be left to user preference IMO.

[markus-jehl]

Have you tried using the actual detector boundaries consistently for BlocksOnCylindrical? I saw that when it's always set to false I get vertical streaks in the reconstruction: Whereas the streaks are gone when I enable the use of the actual detector boundaries:

The logic here: https://github.com/UCL/STIR/blob/5e4fd8c24b889ad666464911c5f150c4bf9271f7/src/recon_buildblock/ProjMatrixByBinUsingRayTracing.cxx#L601C13-L601C32 doesn't make sense for BlocksOnCylindrical, where we never use arc correction. Also this looks problematic, although I'm still trying to wrap my head around the interleaving: https://github.com/UCL/STIR/blob/5e4fd8c24b889ad666464911c5f150c4bf9271f7/src/recon_buildblock/ProjMatrixByBinUsingRayTracing.cxx#L752