UCL / STIR

Software for Tomographic Image Reconstruction
http://stir.sourceforge.net/
Other
104 stars 89 forks source link

VectorWithOffset constructor warnings #1459

Closed KrisThielemans closed 2 weeks ago

KrisThielemans commented 2 weeks ago

https://github.com/UCL/STIR/blob/edccb82c089a34789544f7c2e83241927dd54d63/src/include/stir/VectorWithOffset.inl#L279-L280 gives warnings as the wrong order of arguments is used

/home/kris/devel/build/SIRF-SuperBuild/builds/STIR/build/src/swig/CMakeFiles/_stir.dir/stirPYTHON_wrap.cxx:48419:106:   required from here
/home/kris/devel/build/SIRF-SuperBuild/sources/STIR/src/include/stir/VectorWithOffset.h:400:16: warning: ‘stir::VectorWithOffset<float>::pointer_access’ will be initialized after [-Wreorder]
  400 |   mutable bool pointer_access;
      |                ^~~~~~~~~~~~~~
/home/kris/devel/build/SIRF-SuperBuild/sources/STIR/src/include/stir/VectorWithOffset.h:390:19: warning:   ‘std::shared_ptr<float []> stir::VectorWithOffset<float>::allocated_memory_sptr’ [-Wreorder]
  390 |   shared_ptr<T[]> allocated_memory_sptr;
      |                   ^~~~~~~~~~~~~~~~~~~~~
In file included from /home/kris/devel/build/SIRF-SuperBuild/sources/STIR/src/include/stir/VectorWithOffset.h:405,
                 from /home/kris/devel/build/SIRF-SuperBuild/sources/STIR/src/include/stir/stream.h:28,