Reverting a change that broke the blocks on cylindrical geometry. - Githubissues

UCL / STIR

Software for Tomographic Image Reconstruction

http://stir.sourceforge.net/

Other

104 stars 89 forks source link

Reverting a change that broke the blocks on cylindrical geometry. #1462

Closed markus-jehl closed 2 weeks ago

markus-jehl commented 2 weeks ago

Changes in this pull request

Reverted a part of commit: https://github.com/UCL/STIR/commit/42bf1e98e1cfb3c7fae131fb8590b439ff07068c

Testing performed

Related issues

fixes https://github.com/UCL/STIR/issues/1390

Checklist before requesting a review

[] I have performed a self-review of my code
[] I have added docstrings/doxygen in line with the guidance in the developer guide
[] I have implemented unit tests that cover any new or modified functionality (if applicable)
[] The code builds and runs on my machine
[] documentation/release_XXX.md has been updated with any functionality change (if applicable)

markus-jehl commented 2 weeks ago

@danieldeidda @KrisThielemans This is ready now from my side. The detector coordinate test could clearly be improved since we didn't notice the wrong geometry, but the python plotting tool shows that it is now correct.

KrisThielemans commented 2 weeks ago

Thanks @markus-jehl. Could you add a plot here for future reference? Please also modify the release_6.2.htm.

@danieldeidda please check.

markus-jehl commented 2 weeks ago

danieldeidda commented 2 weeks ago

having a look now

danieldeidda commented 2 weeks ago

just for my understanding could it be possible to see the plot showing the wrong geometry

KrisThielemans commented 2 weeks ago

See https://github.com/UCL/STIR/issues/1390

KrisThielemans commented 2 weeks ago

Excellent. Squash merge ok?