Axial symmetry fixes for BlocksOnCylindrical - Githubissues

UCL / STIR

Software for Tomographic Image Reconstruction

http://stir.sourceforge.net/

Other

111 stars 93 forks source link

Axial symmetry fixes for BlocksOnCylindrical #1466

Closed markus-jehl closed 3 months ago

markus-jehl commented 3 months ago

Changes in this pull request

Fix axial scanner downsampling and correct handling of gaps to make BlocksOnCylindrical axially symmetric.

Testing performed

See before and after in associated issue: https://github.com/UCL/STIR/issues/1465

Related issues

Fixes https://github.com/UCL/STIR/issues/1465 Relates to https://github.com/UCL/STIR/pull/1291

Checklist before requesting a review

[] I have performed a self-review of my code
[] I have added docstrings/doxygen in line with the guidance in the developer guide
[] I have implemented unit tests that cover any new or modified functionality (if applicable)
[] The code builds and runs on my machine
[] documentation/release_XXX.md has been updated with any functionality change (if applicable)

KrisThielemans commented 3 months ago

Could you add a note to release_6.2.htm, as well as the tiny comments on the scanner definition in the test function? (If only textual, commit with [ci skip] in the first line of the commit to prevent Appveyor going again).

markus-jehl commented 3 months ago

Projecting a symmetric cylinder with NeuroLF geometry gives only floating point level differences in symmetry (last plot is first axial half minus flipped second axial half of a viewgram):