use interfile information for frame difinition if all event are used,…

danieldeidda commented 2 days ago

use interfile information for frame difinition if all event are used,… throwing a warning otherwise

Changes in this pull request

use interfile information for frame difinition if all event are used,… throwing a warning otherwise

Testing performed

yes

Related issues

--fixes #1512

Checklist before requesting a review

[v] I have performed a self-review of my code
[] I have added docstrings/doxygen in line with the guidance in the developer guide
[] I have implemented unit tests that cover any new or modified functionality (if applicable)
[v] The code builds and runs on my machine
[] documentation/release_XXX.md has been updated with any functionality change (if applicable)

KrisThielemans commented 1 day ago

most jobs were ok, but one https://github.com/UCL/STIR/pull/1519/checks#step:17:1059 can you check the log file (downloadable from the Actions page).

Also, clang-format issues.

KrisThielemans commented 1 day ago

Can be reproduced by using the following .par file

lm to projdata parameters :=
input file := root_header.hroot
template projdata := template_for_ROOT_scanner.hs
frame definition file :=
num events to store := 0
output filename prefix := my_sinogram_counts_TOF

maximum absolute segment number to process := 3
do pre normalisation := 0
num tof bins in memory := 5
num segments in memory := 7
store prompts := 1
store delayeds := 0
list event coordinates := 0
end :=

and

INPUT_ROOT_FILE=test_PET_GATE.root lm_to_projdata my_lm_to_projdata_counts_TOF.par

which results in

Last stored event was recorded before time-tick at 0 secs
Total number of counts (either prompts/trues/delayeds) stored: 0

This is probably due to the fact that the .hroot file does not contain any time info, so we might need to check if the time from th elm file is valid or not.

UCL / STIR