Open KrisThielemans opened 3 years ago
Some comments:
num_crystals_per_block
, it should use num_crystals_per_bucket
insteadI have given this a shot and while I thought it would be nice and easy, there are ~180 uses of foobar_per_block
mentions that simply need to be replaced with foobar_per_bucket
. Therefore, I will wait for #833 to be merged before I fix this problem otherwise the conflicts will be significant and confusing
re-opened such that we don't forget to rename all the internal functions
As found by @nikefth, @francescaleek and @emikhaylova, the current assumption behind symmetries in
find_ML_normfactors3D
that the scanner is invariant over rotations by block is often incorrect in practice. Most scanners will have a few blocks in a "bucket", and the rotational (and for some scanners even axial translation) symmetry should be applied on the bucket level.If the symmetries are wrong, @francescaleek found that the patterns in the estimated geometric factors will incorrect (mostly underestimated).