Add config file - [merged] #91

Closed tdowrick closed 3 years ago

In GitLab by @RolandGuichard on May 23, 2019, 17:28

_Merges add-config-file -> startdeps

Fixes #60

In GitLab by @RolandGuichard on May 23, 2019, 17:31

changed target branch from master to start_deps

In GitLab by @RolandGuichard on Jun 3, 2019, 08:52

added 1 commit

b9ae36da - Add the pyIGTLink server settings

Compare with previous version

In GitLab by @RolandGuichard on Jun 3, 2019, 09:55

added 2 commits

70315c41 - Add more PLUS settings to config file
758a55ec - Add IGTLink connector name

Compare with previous version

In GitLab by @RolandGuichard on Jun 3, 2019, 11:12

added 1 commit

8916bb02 - Add PLUS path and executables

Compare with previous version

In GitLab by @RolandGuichard on Jun 3, 2019, 11:13

Hi @ThomasDowrick and @AnastasisGeorgoulas could you please review this ? My intention is to test it later this week with the machines. Thanks.

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:37

Commented on skullbasenavigation/config.py line 10

I'm guessing this is 'localhost' :)

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:37

Commented on skullbasenavigation/config.py line 16

I think the executable names could stay hardcoded, if we have the path here.

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:38

Commented on skullbasenavigation/config.py line 22

This is very minor, and just personal preference: I would rename these to BK_... in case we need to connect to the BK a different way (although it is helpful to have the name match the section heading!)

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:39

Commented on skullbasenavigation/config.py line 29

I wonder if we can give these more descriptive names, like PIVOT_CALIBRATION_TF or something that explains what the transforms refer to rather than their names. I'm not sure though!

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:40

Commented on skullbasenavigation/config.py line 48

These two names are fixed (even in different Slicer versions, as far as I can tell), so I would keep them hardcoded rather than put them here.

In GitLab by @AnastasisGeorgoulas on Jun 3, 2019, 11:40

Commented on skullbasenavigation/sbn_slicelet.py line 172

CT_name isn't used in this function, right? I would suggest deleting it if so (we've moved the check for it somewhere else, I think?)

In GitLab by @RolandGuichard on Jun 3, 2019, 13:32

Commented on skullbasenavigation/sbn_slicelet.py line 172

Not sure. By the looks of master, what we do is to set the blank name of the CT_node to SLD-001. That is probably the one name to use. The thing is, where I branched from looks behind the work we did on the nodes renaming/passing around.

In GitLab by @RolandGuichard on Jun 3, 2019, 13:32

Commented on skullbasenavigation/config.py line 48

I vouch for that.

In GitLab by @RolandGuichard on Jun 3, 2019, 13:33

Commented on skullbasenavigation/config.py line 29

Yes, that'd be good. SureTrack2BlurbToWhatever doesn't make any meaningful sense.

In GitLab by @RolandGuichard on Jun 3, 2019, 13:34

Commented on skullbasenavigation/config.py line 22

OK, sounds good to me.

In GitLab by @RolandGuichard on Jun 3, 2019, 13:34

Commented on skullbasenavigation/config.py line 16

OK, good to me.