Open tbhallett opened 2 years ago
Hi @tbhallett - are these suppose to be small individual pull requests or can I commit each change and submit as one PR? I am not sure how to do PR2?
Thanks Ines. Easiest would be a separate PR for each. We can review a single change in one PR much more easily then several things changing together.
Ok re PR2; we can discuss. Basically nothing may need to be done but we need to check how the calibrations look.
Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?
Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?
Hi @tbhallett - sorry I started on ALRI and forgot this PR3 - I will work on it from Monday
Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?
Hi @tbhallett - sorry I started on ALRI and forgot this PR3 - I will work on it from Monday
Thanks @inesll! No urgency from my -- just wanted to see if the issue could be closed or not. Happy to talk about changes next week if useful.
Following discussion, we have agreed re PR3 that the remaining to-do items are completed (i.e. no change is necessary) , but we need to make a minor refinement to the footprints implied in the treatment
HSI.
healthseekingbehaviour
module but we need to check that this is happening correctly and raise an issue if not.HSI_Diarrhoea_Treatment_Outpatient
to take place at level 1a (at which ORS is provided etc).HSI_Diarrhoea_Treatment_Outpatient
should manifest no additional footprint and occur on the same day)We agreed that @tbhallett would make the changes in a PR and ask @inesll and @timcolbourn to review. For that reason, @tbhallett is now assigned this issue.
Here is a set of things to do in subsequent PRs (tick off as we go):