UCL / TLOmodel

Epidemiology modelling framework for the Thanzi la Onse project
https://www.tlomodel.org/
MIT License
10 stars 4 forks source link

Remaining Issues on Diarrhoea Module #367

Open tbhallett opened 2 years ago

tbhallett commented 2 years ago

Here is a set of things to do in subsequent PRs (tick off as we go):

inesll commented 2 years ago

Hi @tbhallett - are these suppose to be small individual pull requests or can I commit each change and submit as one PR? I am not sure how to do PR2?

tbhallett commented 2 years ago

Thanks Ines. Easiest would be a separate PR for each. We can review a single change in one PR much more easily then several things changing together.

Ok re PR2; we can discuss. Basically nothing may need to be done but we need to check how the calibrations look.

tbhallett commented 2 years ago

Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?

inesll commented 2 years ago

Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?

Hi @tbhallett - sorry I started on ALRI and forgot this PR3 - I will work on it from Monday

tbhallett commented 2 years ago

Hi @inesll and @timcolbourn -- shall I close this down? Is PR3 not needed as you agree with the current implementations?

Hi @tbhallett - sorry I started on ALRI and forgot this PR3 - I will work on it from Monday

Thanks @inesll! No urgency from my -- just wanted to see if the issue could be closed or not. Happy to talk about changes next week if useful.

tbhallett commented 2 years ago

Following discussion, we have agreed re PR3 that the remaining to-do items are completed (i.e. no change is necessary) , but we need to make a minor refinement to the footprints implied in the treatment HSI.

We agreed that @tbhallett would make the changes in a PR and ask @inesll and @timcolbourn to review. For that reason, @tbhallett is now assigned this issue.