search

UCL / dxh

Collection of helper functions for working with DOLFINx Python interface
http://github-pages.ucl.ac.uk/dxh/
MIT License
3 stars 0 forks source link

Support DOLFINx 0.7 _and_ 0.6. #12

Closed samcunliffe closed 11 months ago

samcunliffe commented 1 year ago

Re-purposing this stale PR to properly move to 0.7 maintaining backward support to 0.6.

We could actually consider dumping 0.6 completely. It'd certainly mean cleaner code. As it is, I kept in the try-except blocks but did them the other way around. I.e. try to do it the 0.7 way first, and fallback on the 0.6 API.

Solves

Note for reviewers

My comment down here 👇 is now moot, because DOLFINx 0.7 is what we get from pip on the CI.

samcunliffe commented 1 year ago

I'm having an unrelated issue testing this with @janoschpreuss 's dxss fenics_dev branch so converting this to draft for now.

samcunliffe commented 11 months ago

add an extra key to Actions workflow job matrix to have tests run against both v0.6 and v0.7 while we're supporting both, but if we're anticipating dropping support in the near future might not be worth effort.

Yeah, nice idea. What do you think @krishnakumarg1984 should we "officially" support 0.6 (and therefore put it in the CI?)

krishnakumarg1984 commented 11 months ago

I'd slightly prefer just supporting 0.7 alone.