search

UCL / dxh

Collection of helper functions for working with DOLFINx Python interface
http://github-pages.ucl.ac.uk/dxh/
MIT License
3 stars 0 forks source link

Run tests against both DOLFINx v0.6 and v0.7. #15

Closed samcunliffe closed 4 months ago

samcunliffe commented 11 months ago

Now working, thanks mostly to @matt-graham's wisdom his reply to my standup on Friday.

Note that this is also shown to be working via a genuine test failure with DOLFINx v0.6, at the penultimate commit ddd06a3. Due to a version-specific type annotation on main.

I argue that we probably do want to formally support v0.6 because that's what Deepika is using, and minimising breaking changes for her is worth our while, IMO.

A somewhat unimportant bonus is that our coverage goes up as we're now testing all the except ImportError codeblocks ☂️ 💜 .

krishnakumarg1984 commented 11 months ago

This is still a draft, it says.

samcunliffe commented 11 months ago
Screenshot 2023-10-19 at 14 38 09

did you miss click?

krishnakumarg1984 commented 11 months ago

Yes. Please ignore.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.2%. Comparing base (e48a665) to head (4a34ac6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #15 +/- ## ======================================= + Coverage 91.9% 96.2% +4.4% ======================================= Files 1 1 Lines 183 183 Branches 36 36 ======================================= + Hits 168 176 +8 + Misses 12 5 -7 + Partials 3 2 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.