UCL / frrant

2 stars 0 forks source link

Feature/commentary mentions box #428

Closed acholyn closed 7 months ago

acholyn commented 7 months ago

closes #413

Created new PublicCommentaryMentions model, which is a simpler version of TextObjectField, it has a 1:1 relationship with models that have commentaries. On the detail page, this section can be toggled when editing and can be edited itself. It does not have a plain version, nor tracks mentions as it should be a slimmed down version of the actual Commentary, purely for public consumption and ergo the duplication is unnecessary.

It utilises the same htmx inline update flow as introductions and commentaries.

tcouch commented 7 months ago

One small bug:

And another (probably my fault from when I set it up)

Do we actually need the toggle on the edit page?

acholyn commented 7 months ago

we might not even need the toggle in that case, we could show it in all cases except when not approved and not edit (will show for not approved and edit, approved and edit & approved and not edit)

tcouch commented 7 months ago

Ah, one more thing:

  1. Edit a Testimonium
  2. Create public commentary
  3. Do not tick approved
  4. Finish editing
  5. The detail page still shows the public commentary, but "See Also" isn't shown

Not sure if it's just Tesimonia or all types

acholyn commented 7 months ago

Weird, that's not the behaviour on my machine - if it's not approved it doesn't show. Did you pull in the latest changes? When it has been approved, the second box will show without the 'see also' underneath the commentary; not sure if in the final version they want to just leave it being called commentary or not

acholyn commented 7 months ago

ah, ooh I've got a new bug where it shows up twice though